Added GCS support guide to template files #233
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ammarhusain-EMR
requested review from
JD-Robertson,
prestwick,
BKnight760,
lnowotny,
Christian-Nunnally and
MelissaHilliard
as code owners
ammarhusain-EMR
changed the title
prestwick
approved these changes
Dec 5, 2024
|
Following our last discussion, I will keep this PR active. |
1 task
prestwick
requested changes
Jan 24, 2025
| ## Access key information for S3/MinIO access. | ||
| ## If using MinIO, use the user and password from the MinIO configuration above here. Otherwise, S3 credentials will need to be provided. | ||
| ## Access key information for S3/MinIO/GCS access. | ||
| ## If using MinIO, use the user and password from the MinIO configuration above here. Otherwise, S3/GCS credentials will need to be provided. |
There was a problem hiding this comment.
Note, in recent PRs we've removed references to MinIO since its not longer supported and included in our top level Helm chart. Review the latest versions of these templates to ensure your additions align with this change.
There was a problem hiding this comment.
Note, the comment applies to both files changed in this PR and not just this single line.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this Pull Request accomplish?
Added comments to help the user configure GCS as object storage for SLE using the template values and secrets file.
Note: GCS support is not yet added to
dataframe service. Because in dataframe service we are using S3 DeleteObjects API which is not supported by GCS S3 interoperable XML API, refer this for more information. The respective documentation for the dataframe service will be updated once we add this support.Why should this Pull Request be merged?
Helps the user configure GCS as an object storage solution in SystemLink Enterprise except for Dataframe service.
What testing has been done?
NA